Add failsafe related platform config features #3191
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.
👉 Please mark this as DRAFT unless there's an intention to merge this immediately. |
Generated file outputs:Time updated: Mon, 19 May 2025 16:22:57 GMT legacytrackers-unprotected-temporary.txtv3/android-config.json (11 more)
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -6941,8 +6941,12 @@
"reason": "https://github.com/duckduckgo/privacy-configuration/pull/2228"
}
]
},
+ "iOSBrowserConfig": {
+ "exceptions": [],
+ "state": "disabled"
+ },
"incontextSignup": {
"exceptions": [],
"state": "disabled"
},
@@ -6961,8 +6965,12 @@
}
},
"exceptions": []
},
+ "macOSBrowserConfig": {
+ "exceptions": [],
+ "state": "disabled"
+ },
"maliciousSiteProtection": {
"state": "disabled",
"exceptions": [
{
v3/ios-config.json--- v3/ios-config.json
+++ v3/ios-config.json
@@ -7049,8 +7049,12 @@
"reason": "https://github.com/duckduckgo/privacy-configuration/pull/2228"
}
]
},
+ "iOSBrowserConfig": {
+ "exceptions": [],
+ "state": "enabled"
+ },
"incontextSignup": {
"exceptions": [],
"state": "enabled",
"minSupportedVersion": "7.87.0",
@@ -7073,8 +7077,12 @@
}
},
"exceptions": []
},
+ "macOSBrowserConfig": {
+ "exceptions": [],
+ "state": "disabled"
+ },
"maliciousSiteProtection": {
"state": "enabled",
"exceptions": [
{
v3/macos-config.json--- v3/macos-config.json
+++ v3/macos-config.json
@@ -7087,8 +7087,12 @@
"reason": "https://github.com/duckduckgo/privacy-configuration/pull/2228"
}
]
},
+ "iOSBrowserConfig": {
+ "exceptions": [],
+ "state": "disabled"
+ },
"incontextSignup": {
"exceptions": [],
"state": "enabled"
},
@@ -7113,8 +7117,12 @@
}
},
"exceptions": []
},
+ "macOSBrowserConfig": {
+ "exceptions": [],
+ "state": "enabled"
+ },
"maliciousSiteProtection": {
"state": "enabled",
"exceptions": [
{
latestv4/android-config.json (11 more)
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -6400,8 +6400,12 @@
"domain": "flexmls.com"
}
]
},
+ "iOSBrowserConfig": {
+ "exceptions": [],
+ "state": "disabled"
+ },
"incontextSignup": {
"exceptions": [],
"state": "disabled"
},
@@ -6420,8 +6424,12 @@
}
},
"exceptions": []
},
+ "macOSBrowserConfig": {
+ "exceptions": [],
+ "state": "disabled"
+ },
"maliciousSiteProtection": {
"state": "disabled",
"exceptions": [
{
v4/ios-config.json--- v4/ios-config.json
+++ v4/ios-config.json
@@ -6507,8 +6507,12 @@
"domain": "flexmls.com"
}
]
},
+ "iOSBrowserConfig": {
+ "exceptions": [],
+ "state": "enabled"
+ },
"incontextSignup": {
"exceptions": [],
"state": "enabled",
"minSupportedVersion": "7.87.0",
@@ -6531,8 +6535,12 @@
}
},
"exceptions": []
},
+ "macOSBrowserConfig": {
+ "exceptions": [],
+ "state": "disabled"
+ },
"maliciousSiteProtection": {
"state": "enabled",
"exceptions": [
{
v4/macos-config.json--- v4/macos-config.json
+++ v4/macos-config.json
@@ -6534,8 +6534,12 @@
"domain": "flexmls.com"
}
]
},
+ "iOSBrowserConfig": {
+ "exceptions": [],
+ "state": "disabled"
+ },
"incontextSignup": {
"exceptions": [],
"state": "enabled"
},
@@ -6560,8 +6564,12 @@
}
},
"exceptions": []
},
+ "macOSBrowserConfig": {
+ "exceptions": [],
+ "state": "enabled"
+ },
"maliciousSiteProtection": {
"state": "enabled",
"exceptions": [
{
|
|
Still more questions before I can address this. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/414235014887631/task/1210248783002400?focus=true
Description
As discussed in ✓ Technical Design: Default values for native app feature flags, for all feature flags with a default local value of enabled (AKA Failsafe feature flags) that don't belong in any other top-level feature of the Privacy Remote Configuration, we should define them as children of respective macOSBrowserConfig or iOSBrowserConfig to avoid needing to add a new top-level feature every time we want to disable a feature of this kind.
Feature change process:
Site breakage mitigation process:
Brief explanation